python312Packages.nodriver: init at 0.34 #326242
Conversation
|
Result of 4 packages built:
|
|
Builds, and also works. Just tested it with the more complex example from their README, and there were no issues. So as soon as this has the changes suggested by @Aleksanaa, this has my approval. |
natsukium
changed the title
|
Hey @natsukium @Aleksanaa @ToasterUwU thanks for looking at this package. I will make the requested changes later today ! |
liam-murphy14
force-pushed
the
add-python-nodriver
branch
from
afdc194
to
ca68cb5
Compare
|
Hey @Aleksanaa and @natsukium, updated with all your suggestions, thanks again !! Let me know if you have any more thoughts. |
liam-murphy14
force-pushed
the
add-python-nodriver
branch
from
ca68cb5
to
aa2bd17
Compare
|
@liam-murphy14 I think you should rerequest reviews now that you fixed the things they wanted changed, that way they will see it and also approve |
|
@ofborg build python312Packages.nodriver |
|
Result of 4 packages built:
|
liam-murphy14
force-pushed
the
add-python-nodriver
branch
from
aa2bd17
to
b77164b
Compare
liam-murphy14
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4276 |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 4 packages built:
|
liam-murphy14
force-pushed
the
add-python-nodriver
branch
from
b77164b
to
d193304
Compare
|
Result of 4 packages built:
|
|
@natsukium @Aleksanaa Sorry for the ping, if you dont have time atm, just ignore the rest of the message. I just want to send a little reminder that the changes you requested have been implemented and that we are waiting for your reviews. Both of you seem to have merge permissions, so it would be very nice if we could get this merged any time soon now that all issues are resolved. |
|
@ofborg build python312Packages.nodriver |
Description of changes
Add python package for nodriver. homepage: https://github.com/ultrafunkamsterdam/nodriver
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.