Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oqs-provider: init at 0.6.1 #326373

Merged
merged 2 commits into from
Aug 3, 2024
Merged

oqs-provider: init at 0.6.1 #326373

merged 2 commits into from
Aug 3, 2024

Conversation

Rixxc
Copy link
Contributor

@Rixxc Rixxc commented Jul 11, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Rixxc Rixxc force-pushed the oqs-provider branch 2 times, most recently from 89bc701 to bc29258 Compare July 13, 2024 08:22
@Rixxc
Copy link
Contributor Author

Rixxc commented Jul 13, 2024

Hey, Thanks for the feedback. I've implemented your requests. Please let me know if there is anything else that needs to be changed.

@sikmir
Copy link
Member

sikmir commented Jul 13, 2024

Result of nixpkgs-review pr 326373 run on x86_64-darwin 1

1 package built:
  • oqs-provider

@sikmir
Copy link
Member

sikmir commented Jul 13, 2024

Result of nixpkgs-review pr 326373 run on x86_64-linux 1

1 package built:
  • oqs-provider

@Rixxc
Copy link
Contributor Author

Rixxc commented Jul 31, 2024

Hey, I think I've made all the changes you requested. Is there anything else I should do to get this PR merged?

@Aleksanaa Aleksanaa merged commit 88ad563 into NixOS:master Aug 3, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants