Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] apptainer: 1.3.2 -> 1.3.3, singularity: 4.1.3 -> 4.1.4 #326615

Conversation

ShamrockLee
Copy link
Contributor

Description of changes

Backport #324415 and #323182 and bump Apptainer and SingularityCE patch-version updates.

Given the frequency with which Apptainer and SingularityCE receive security updates, it might be a good idea to backport every patch and minor version update to make security updates easier.

Cc:
@GaetanLepage. Thank you for bringing every Apptainer/SinglarityCE update to Nixkgs.
@jbedo
@SomeoneSerge

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@infinisil
Copy link
Member

See #326628 for the formatting failure

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM :)

@ShamrockLee ShamrockLee force-pushed the backport-24.05-apptainer-singularity-update branch from f0fbb66 to b0b8ceb Compare July 12, 2024 20:55
@ShamrockLee
Copy link
Contributor Author

See #326628 for the formatting failure

Thank you for inspecting the formatting issue and speedily fixing the problem!

I rebased this pull request onto the tip of release-24.05 to address the CI failure.

@ofborg ofborg bot requested a review from jbedo July 13, 2024 01:44
@SomeoneSerge SomeoneSerge merged commit 85a989b into NixOS:release-24.05 Jul 15, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants