docs: allow building in sandbox on darwin #326653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason `zip` in this case doesn't seem to be respecting the `$TMP` or `$TMPDIR` variables, resulting in a permission denied error on Darwin when sandbox is enabled. The `-b` flag allows one to manually specify a tempdir, which allows the build to succeed in spite of sandboxing. Fixes NixOS#326380
|
cc @NixOS/documentation-team |
ofborg
bot
added
6.topic: darwin
|
I believe this was fixed with NixOS/nix#11031 and i believe the fix has made it to nixpkgs |
@emilazy has some knowledge about the darwin sandbox stuff going on recently. |
|
See #326380 (comment). This PR seems fine to me, although |
|
Why was @emilazy's comment ignored? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason
zipin this case doesn't seem to be respecting the$TMPor$TMPDIRvariables, resulting in a permission denied error onDarwin when sandbox is enabled.
The
-bflag allows one to manually specify a tempdir, which allows thebuild to succeed in spite of sandboxing.
Fixes #326380
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.