Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s7: init at 0-unstable-2024-09-02 #326772

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

s7: init at 0-unstable-2024-09-02 #326772

wants to merge 2 commits into from

Conversation

rc-zb
Copy link
Contributor

@rc-zb rc-zb commented Jul 13, 2024

Description of changes

Add s7, another Scheme interpreter.

And add myself to the maintainer lists of Nixpkgs as well as this package.

Limitations

  • The legacy REPL implemented via repl.scm is not built. Currently s7 is a symbolic link to s7-nrepl, which is built with nrepl.scm according to the upstream script.
    • I know nothing about the C toolchain, and can't script it by myself. I'll be grateful for anything helpful.
  • The upstream test suite (s7test.scm) is not run, for that it seems to include calls towards some libraries not needed for the base application.
  • Batteries from the upstream are not included in the output.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@rc-zb rc-zb changed the title s7: init at 0-unstable-2024-07-12 s7: init at 0-unstable-2024-09-02 Sep 3, 2024
@rc-zb rc-zb marked this pull request as ready for review September 3, 2024 02:15
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants