Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweego: init at 2.1.1 #326795

Merged
merged 2 commits into from
Jul 24, 2024
Merged

tweego: init at 2.1.1 #326795

merged 2 commits into from
Jul 24, 2024

Conversation

ChrisPWill
Copy link
Contributor

Description of changes

Tweego is a compiler for Twine/Twee projects - a popular tool used for authoring interactive text fiction.
https://www.motoslave.net/tweego/

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
    Compiled a basic project following instructions on website and it all worked as expected.
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@redyf
Copy link
Member

redyf commented Jul 13, 2024

Result of nixpkgs-review pr 326795 run on x86_64-linux 1

1 package built:
  • tweego

@ChrisPWill
Copy link
Contributor Author

ChrisPWill commented Jul 14, 2024

@NixOS/nixpkgs-merge-bot merge

Edit: oops I'm new to this wasn't sure if that was my next step.

Thanks for the review! Let me know if there's any other info I can provide.

@nixpkgs-merge-bot
Copy link
Contributor

@ChrisPWill merge not permitted (#305350):
maintainers/maintainer-list.nix is not in pkgs/by-name/

1 similar comment
@nixpkgs-merge-bot
Copy link
Contributor

@ChrisPWill merge not permitted (#305350):
maintainers/maintainer-list.nix is not in pkgs/by-name/

Copy link
Contributor

@pbsds pbsds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also reorder the two commits, so the maintainer addition comes first

pkgs/by-name/tw/tweego/package.nix Outdated Show resolved Hide resolved
@Aleksanaa Aleksanaa merged commit 712925a into NixOS:master Jul 24, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants