Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocis-bin: support more architectures and add update script #326809

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

Ramblurr
Copy link
Contributor

  • Adds an update script that can be used by the passthru updateScript 0
  • Adds the full range of architectures released by owncloud
    • darwin: amd64, aarch64
    • linux: i686, x86_64, arm, aarch64

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Ramblurr
Copy link
Contributor Author

@bhankas As we discussed :) here is the new PR that adds new architectures and an updater script that tracks the Production channel of ocis, not the Rolling channel.

* Adds an update script that can be used by the passthru updateScript [0]
    * this script tracks the Production (aka stable) channel for oCIS https://owncloud.dev/ocis/release_roadmap/#release-types as decided by the package maintainers
* Adds the full range of architectures released by owncloud
    * darwin: amd64, aarch64
    * linux: i686, x86_64, arm, aarch64

[0]: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#automatic-package-updates
Copy link
Contributor

@bhankas bhankas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM!

Copy link
Contributor

@danth danth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too :)

@wegank wegank merged commit b9d52e7 into NixOS:master Jul 15, 2024
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants