Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipper2: use lib.platforms.all #326844

Merged
merged 2 commits into from
Jul 17, 2024
Merged

clipper2: use lib.platforms.all #326844

merged 2 commits into from
Jul 17, 2024

Conversation

thecaralice
Copy link
Contributor

Description of changes

While there might actually be broken platforms, there is no reason to limit supported platforms to just Linux systems.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@cadkin cadkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, I actually ended up changing the platforms myself on an internal branch of nixpkgs recently so it's good to have this upstream as well.

This can be merged, but probably should wait until #326810 is in first.

@wegank
Copy link
Member

wegank commented Jul 17, 2024

Result of nixpkgs-review pr 326844 run on aarch64-darwin 1

1 package built:
  • clipper2

While there might actually be broken platforms, there is no reason
to limit supported platforms to just Linux systems.
@ofborg ofborg bot requested a review from cadkin July 17, 2024 02:43
@wegank wegank merged commit 1440058 into NixOS:master Jul 17, 2024
24 of 26 checks passed
@thecaralice thecaralice deleted the clipper2 branch July 26, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants