-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drumkv1: 0.9.23 -> 1.0.0 (+fix LV2 Qt UI issues) #326887
base: master
Are you sure you want to change the base?
Conversation
added myself as maintainer of the package since the original maintainer ("goibhniu") is gone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please drop the merge commit from this PR.
@@ -21,4 +56,4 @@ mkDerivation rec { | |||
platforms = platforms.linux; | |||
maintainers = [ maintainers.goibhniu ]; | |||
}; | |||
} | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the final newline back and configure your editor to always add that.
cmakeFlags = [ "-DCONFIG_LV2_PORT_CHANGE_REQUEST=false" ]; # disable experimental feature "LV2 port change request" | ||
|
||
installPhase = let | ||
lv2Dir = "$out/lib/lv2/drumkv1.lv2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lv2Dir = "$out/lib/lv2/drumkv1.lv2"; | |
lv2Dir = "$out/lib/lv2/drumkv1.lv2"; |
runHook preInstall | ||
make install | ||
mkdir -p ${lv2Dir} | ||
# -- some workaround, since it always wants to install to /$out/$out -- # |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means the install location in the cmake file is wrong. Please fix that. It likely needs FULL_INSTALL_DIR or so instead. This should also be upstreamed
runHook postInstall | ||
rm -r $out/nix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runHook postInstall | |
rm -r $out/nix | |
rm -r $out/nix | |
runHook postInstall |
runHook preInstall | ||
make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move everything into postInstall and avoid calling make install by hand.
nativeBuildInputs = [ pkg-config ]; | ||
nativeBuildInputs = [ pkg-config cmake qt6.wrapQtAppsHook ]; | ||
|
||
cmakeFlags = [ "-DCONFIG_LV2_PORT_CHANGE_REQUEST=false" ]; # disable experimental feature "LV2 port change request" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmakeFlags = [ "-DCONFIG_LV2_PORT_CHANGE_REQUEST=false" ]; # disable experimental feature "LV2 port change request" | |
cmakeFlags = [ | |
# disable experimental feature "LV2 port change request" | |
"-DCONFIG_LV2_PORT_CHANGE_REQUEST=false" | |
]; |
libsndfile | ||
liblo | ||
lv2 | ||
qt6.full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please list the package individually instead of relying on the big qt6.full
pname = "drumkv1"; | ||
version = "0.9.23"; | ||
version = "1.0.0"; | ||
|
||
src = fetchurl { | ||
url = "mirror://sourceforge/drumkv1/${pname}-${version}.tar.gz"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url = "mirror://sourceforge/drumkv1/${pname}-${version}.tar.gz"; | |
url = "mirror://sourceforge/drumkv1/drumkv1-${version}.tar.gz"; |
@@ -1,4 +1,4 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a squashed in the previous commit
d538183
to
e7fff86
Compare
f90d512
to
223dec5
Compare
I now reworked my commits (and dropped the merge), I hope I implemented everything correctly... |
Please rebase on master |
1590637
to
ddacfbe
Compare
ddacfbe
to
d193c5e
Compare
Ah, thanks for reminding me, I didn't have collisions in a PR before... |
Description of changes
Updated the drumkv1 drum sampler from version 0.9.23 to 1.0.0 (changelog: https://drumkv1.sourceforge.io/drumkv1-downloads.html, couldn't find any better one) and added xorg.libX11 to the dependencies.
As this is my first pull-request I hope I didn't do anything completely wrong, met all guidelines and don't cause a huge waste of time.
Things done
After I found out that the original maintainer was gone:
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.