vkquake: 1.22.3 → 1.31.0 #329327
Merged
vkquake: 1.22.3 → 1.31.0 #329327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gliczy
approved these changes
Jul 24, 2024
|
yooooo hope this gets merged |
pkgs/games/quakespasm/vulkan.nix
Outdated
Comment on lines
35
to
39
| glslang | ||
| meson | ||
| ninja | ||
| pkg-config | ||
| vulkan-headers |
There was a problem hiding this comment.
Aren't glslang/vulkan-headers supposed to go in buildInputs?
There was a problem hiding this comment.
I actually just removed the vulkan-headers depedency all together and it still works, so I'm guessing it's unnecessary.
|
@SuperSandro2000 Would it be good to move this to |
|
Also, can I add myself as a maintainer? |
|
The title for the commit adding you to the maintainers list should be |
poperigby
force-pushed
the
vkquake-1.31.0
branch
from
ea08fdc
to
e55ed5e
Compare
Thanks for letting me know. Fixed. |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Novum/vkQuake/releases/tag/1.31.0
Description of changes
I updated vkQuake from 1.22.3 to 1.31.0. I converted it to use Meson and Ninja instead of Make, as that's the new recommended way to build it.
Closes #329318
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.