Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.scikit-fuzzy: unstable-2022-11-07 -> unstable-2023-09-14 #330854

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Sigmanificient
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 29, 2024

@emilazy getting this weird build failure from the checkPhase

============================= test session starts ==============================
platform linux -- Python 3.12.4, pytest-7.4.4, pluggy-1.5.0
rootdir: /build/source
configfile: pyproject.toml
collected 166 items / 1 error                                                  
run-last-failure: None

==================================== ERRORS ====================================
____________ ERROR collecting skfuzzy/cluster/tests/test_cmeans.py _____________
import file mismatch:
imported module 'test_cmeans' has this __file__ attribute:
  /build/source/build/lib/skfuzzy/cluster/tests/test_cmeans.py
which is not the same as the test file we want to collect:
  /build/source/skfuzzy/cluster/tests/test_cmeans.py
HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules
=========================== short test summary info ============================
ERROR skfuzzy/cluster/tests/test_cmeans.py
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 1.00s ===============================

@emilazy
Copy link
Member

emilazy commented Jul 29, 2024

Looks like some issue with running tests out of tree. It’s beyond my expertise without doing a bunch of digging; hopefully someone else can take a look.

@lavafroth
Copy link
Contributor

lavafroth commented Jul 29, 2024

I'll look at the build failures. Looks good otherwise.

@lavafroth
Copy link
Contributor

I figured, we gotta remove the build dir during the checkPhase. I added the following:

  checkPhase = ''
    rm -rf build
  '';

@lavafroth
Copy link
Contributor

lavafroth commented Jul 29, 2024 via email

@bcdarwin
Copy link
Member

I guess that'd be more appropriate, yeah. Also, I just tested that we can run pytest skfuzzy in the checkPhase to point to the appropriate directory.

The current version using preCheck is fine, but in the other case pytestFlagsArray = [ "skfuzzy" ] would be preferred here.

emilazy
emilazy previously requested changes Aug 9, 2024
pkgs/development/python-modules/scikit-fuzzy/default.nix Outdated Show resolved Hide resolved
@Sigmanificient
Copy link
Member Author

done

@SuperSandro2000
Copy link
Member

@ofborg build python312Packages.scikit-fuzzy python312Packages.intensity-normalization

@SuperSandro2000 SuperSandro2000 merged commit ffeaefa into NixOS:master Aug 22, 2024
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants