Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.mdformat-wikilink: init at 0.2.0 #331006

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

python312Packages.mdformat-wikilink: init at 0.2.0 #331006

wants to merge 2 commits into from

Conversation

MattKang
Copy link

@MattKang MattKang commented Jul 30, 2024 •
edited
Loading

Description of changes

Add mdformat-wikilink Python package

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MattKang MattKang requested a review from natsukium as a code owner July 30, 2024 04:08
@MattKang
Copy link
Author

MattKang commented Jul 31, 2024 •
edited
Loading

@natsukium Not sure if I'm doing something wrong but passthru.tests is listed as queued, but I think it's succeeded?

@natsukagami
Copy link
Contributor

I believe you wanted to mention @natsukium (deja vu?). The wonders of sharing a 6 letter prefix username 😂

@MattKang MattKang mentioned this pull request Jul 31, 2024
Open
@MattKang
Copy link
Author

MattKang commented Aug 5, 2024

@natsukium is there anything else I need to do to get this merged?

@MattKang
Copy link
Author

MattKang commented Aug 6, 2024

@dotlambda pinging as you left feedback on my other PR. Is there anything else I need to do to get this merged? Apologies as I'm new to contributing.

natsukium
natsukium requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review.

pkgs/development/python-modules/mdformat-wikilink/default.nix Outdated

nativeBuildInputs = [
poetry-core
pytest-cov
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pytest-cov

pytest-cov is a pytest-plugin for tests, so we don't need it in nativeBuildInputs.
Also, we don't want to measure coverage because we test for packaging correctness.

Copy link
Author

@MattKang MattKang Aug 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing that there might be an issue with this as reported by the ofborg build. Do you have any suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove --cov=... with substituteInPlace in postPatch.

pkgs/development/python-modules/mdformat-wikilink/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mdformat-wikilink/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/mdformat-wikilink/default.nix Outdated Show resolved Hide resolved
@MattKang MattKang force-pushed the add-mdformat-wikilink branch 2 times, most recently from 3609545 to 43f4e0b Compare August 9, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@natsukium natsukium natsukium requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
6.topic: python 8.has: maintainer-list (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MattKang @natsukagami @dotlambda @natsukium