Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vapoursynth-{eedi3,nnedi3cl,nnedi3,znedi3}: init #332285

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

vapoursynth-{eedi3,nnedi3cl,nnedi3,znedi3}: init #332285

wants to merge 5 commits into from
+212 −0

Conversation

snaakey
Copy link
Member

@snaakey snaakey commented Aug 4, 2024 •
edited
Loading

Description of changes

Addition of vapoursynth deinterlacing plugins:

  • eedi3: unstable-2019-09-30
  • nnedi3cl: 8
  • nnedi3: 12
  • znedi3: unstable-2023-07-09

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Aug 4, 2024
@snaakey snaakey force-pushed the vapoursynth-deinterlacing branch 3 times, most recently from 35dfd89 to 9bd6369 Compare August 4, 2024 18:28
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 4, 2024
@illdefined
Copy link
Contributor

Result of nixpkgs-review pr 332285 run on x86_64-linux 1

3 packages built:
  • vapoursynth-eedi3
  • vapoursynth-nnedi3cl
  • vapoursynth-znedi3

@illdefined
Copy link
Contributor

Have you tested the OpenCL‐based plugins?

illdefined
illdefined approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@illdefined illdefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested all four plugins.

@illdefined illdefined added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illdefined illdefined illdefined approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snaakey @illdefined