-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codecrafters-cli: init at 34 #332505
codecrafters-cli: init at 34 #332505
Conversation
67244f6
to
2b3cf93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can update the commit hash automatically when updating the rest of the package by taking this approach.1
Also: Could you please format this using pkgs.nixfmt-rfc-style
to fix this failed CI check?
Footnotes
-
Here's some other examples of where this pattern has been used: https://github.com/search?q=repo%3ANixOS%2Fnixpkgs%20%24out%2FCOMMIT&type=code ↩
2b3cf93
to
41ad41e
Compare
I've formatted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Good sleuthing with the ldflags
!
Yes, you were right, the maintainer list shouldn't be formatted (in this PR, at least).
41ad41e
to
176f405
Compare
176f405
to
95c8197
Compare
Updates the email for builditluc and adds a GPG fingerprint
95c8197
to
0d86cec
Compare
@afh, I've just replaced the weird stuff with |
Result of 1 package built:
|
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the review feedback, @Builditluc, much appreciated 👍
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1892 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thank you for addressing everything pointed out!
Description of changes
The CodeCrafters CLI, codecrafters, is a command-line tool that allows you to run tests & view test results of the current stage from your local machine.
Link to the homepage: https://codecrafters.io/
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.