codecrafters-cli: init at 34

[Builditluc]

Description of changes

The CodeCrafters CLI, codecrafters, is a command-line tool that allows you to run tests & view test results of the current stage from your local machine.

Link to the homepage: https://codecrafters.io/

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[tomodachi94]

We can update the commit hash automatically when updating the rest of the package by taking this approach.¹

Also: Could you please format this using pkgs.nixfmt-rfc-style to fix this failed CI check?

Footnotes

1. Here's some other examples of where this pattern has been used: https://github.com/search?q=repo%3ANixOS%2Fnixpkgs%20%24out%2FCOMMIT&type=code ↩

[Builditluc]

Also: Could you please format this using pkgs.nixfmt-rfc-style to fix this failed CI check?

I've formatted the package.nix file, but the updated maintainers list is not formatted. Wouldn't this cause merge conflicts for others if I modify the file through nixfmt?

[tomodachi94]

Lgtm. Good sleuthing with the ldflags!

Yes, you were right, the maintainer list shouldn't be formatted (in this PR, at least).

[Builditluc]

@afh, I've just replaced the weird stuff with rm -rf and verified again that the package builds correctly. If you have nothing more to add, I think the PR would be ready to be merged

[afh]

Result of nixpkgs-review pr 332505 run on x86_64-linux 1

1 package built:

• codecrafters-cli

[afh]

Result of nixpkgs-review pr 332505 run on aarch64-darwin 1

1 package built:

• codecrafters-cli

[afh]

Thanks for addressing all the review feedback, @Builditluc, much appreciated 👍

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1892

[tomodachi94]

Lgtm, thank you for addressing everything pointed out!