Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aerogramme: init at 0.3.0 #332674

Merged
merged 2 commits into from
Aug 8, 2024
Merged

aerogramme: init at 0.3.0 #332674

merged 2 commits into from
Aug 8, 2024

Conversation

supinie
Copy link
Contributor

@supinie supinie commented Aug 6, 2024

Description of changes

A resilient and standards-compliant open-source IMAP server with server-side encryption.

https://aerogramme.deuxfleurs.fr/
https://git.deuxfleurs.fr/Deuxfleurs/aerogramme

NOTE: This PR must be merged after #331111 where I will be added to maintainers/maintainer-list.nix. Tests are expected to fail because of this.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SigmaSquadron
Copy link
Contributor

NOTE: This PR must be merged after #331111 where I will be added to maintainers/maintainer-list.nix. Tests are expected to fail because of this.

Feel free to add that commit to this PR as well. If they're identical, they should be merged with no conflicts.

@fpletz
Copy link
Member

fpletz commented Aug 7, 2024

Since upstream even provides a flake I don't see any benefit in adding another 100kb Cargo.lock to nixpkgs.

@supinie
Copy link
Contributor Author

supinie commented Aug 7, 2024

Since upstream even provides a flake I don't see any benefit in adding another 100kb Cargo.lock to nixpkgs.

Sorry, this is one of my first packages and am fairly unfamiliar with flakes - how should this be addressed otherwise?

@JulienMalka
Copy link
Member

Result of nixpkgs-review pr 332674 run on x86_64-linux 1

1 package built:
  • aerogramme

Copy link
Member

@JulienMalka JulienMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@JulienMalka JulienMalka merged commit 6017bb2 into NixOS:master Aug 8, 2024
32 of 33 checks passed
@fpletz
Copy link
Member

fpletz commented Aug 9, 2024

Sorry, this is one of my first packages and am fairly unfamiliar with flakes - how should this be addressed otherwise?

Users could just import the repo or use the flake instead of adding this to nixpkgs.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-summer-of-nix-program-updates/46053/4

@supinie supinie deleted the aerogramme branch August 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants