maintainers: add phanirithvij, init distrobox-tui, gh-i, gitcs, go-mtree, gup #332765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
phanirithvij
force-pushed
the
initial-contrib
branch
from
510eb73
to
49555db
Compare
phanirithvij
changed the title
phanirithvij
changed the title
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4377 |
kirillrdy
reviewed
Aug 6, 2024
kirillrdy
reviewed
Aug 6, 2024
phanirithvij
force-pushed
the
initial-contrib
branch
from
d5c3f65
to
c7332ef
Compare
katexochen
reviewed
Aug 7, 2024
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
tests disabled but binary works as expected Signed-off-by: phanirithvij <phanirithvij2000@gmail.com> Update pkgs/by-name/go/go-mtree/package.nix Co-authored-by: Paul Meyer <49727155+katexochen@users.noreply.github.com> Update pkgs/by-name/go/go-mtree/package.nix Co-authored-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
phanirithvij
force-pushed
the
initial-contrib
branch
from
11ea897
to
bbf1124
Compare
|
Result of 5 packages built:
|
katexochen
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Setxattrsyscall not working with nix since it is read-onlygo test ./...on nixos and it passes, v0.5.4 tag of go-mtree.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.