mailsy: init at 5.0.0 #332859
mailsy: init at 5.0.0 #332859
Conversation
github-actions
bot
added
6.topic: python
6.topic: nixos
8.has: module (update)
6.topic: lib
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4426 |
pkgs/by-name/ma/mailsy/package.nix
Outdated
| meta = with lib; { | ||
| description = "Quickly generate a disposable email straight from terminal"; | ||
| mainProgram = "mailsy"; | ||
| homepage = "https://fig.io/manual/mailsy"; | ||
| license = licenses.mit; | ||
| maintainers = [maintainers._404wolf]; | ||
| }; |
There was a problem hiding this comment.
Don't use with lib; (see #208242)
| meta = with lib; { | |
| description = "Quickly generate a disposable email straight from terminal"; | |
| mainProgram = "mailsy"; | |
| homepage = "https://fig.io/manual/mailsy"; | |
| license = licenses.mit; | |
| maintainers = [maintainers._404wolf]; | |
| }; | |
| meta = { | |
| description = "Quickly generate a disposable email straight from terminal"; | |
| mainProgram = "mailsy"; | |
| homepage = "https://fig.io/manual/mailsy"; | |
| license = lib.licenses.mit; | |
| maintainers = [ lib.maintainers._404wolf ]; | |
| }; |
pkgs/by-name/ma/mailsy/package.nix
Outdated
|
|
||
| dontNpmBuild = true; | ||
|
|
||
| patches = [./fix-file-lookup.patch]; |
There was a problem hiding this comment.
The patch is pretty simple, so we can just do this instead:
| patches = [./fix-file-lookup.patch]; | |
| postPatch = '' | |
| substituteInPlace utils/index.js \ | |
| --replace-fail 'dirname, "../data/account.json"' 'process.cwd(), "account.json"' \ | |
| --replace-fail 'dirname, "../data/email.html"' 'process.cwd() + "email.html"' | |
| ''; |
pkgs/by-name/ma/mailsy/package.nix
Outdated
|
|
||
| npmDepsHash = "sha256-ljmqNmLvRHPdsKyOdDfECBXHTIExM6nPZF45lqV+pDM="; | ||
|
|
||
| npmFlags = ["--legacy-peer-deps"]; |
There was a problem hiding this comment.
The file doesn't seem to be properly formatted. You should format it with nixfmt
pkgs/by-name/ma/mailsy/package.nix
Outdated
| buildNpmPackage, | ||
| fetchFromGitHub, | ||
| lib, |
There was a problem hiding this comment.
This is more of a cosmetic thing (as far as I know), but lib is usually the first input of the derviation.
| buildNpmPackage, | |
| fetchFromGitHub, | |
| lib, | |
| lib, | |
| buildNpmPackage, | |
| fetchFromGitHub, |
|
Also, the commit message is missing a - mailsy init at 5.0.0
+ mailsy: init at 5.0.0You should also change the PR title to this. |
|
@eljamm Thank you very much for the feedback, I've gone ahead and made the suggested changes! :) |
mailsy init at 5.0.0
pkgs/by-name/ma/mailsy/package.nix
Outdated
| @@ -0,0 +1,32 @@ | |||
| { lib, buildNpmPackage, fetchFromGitHub, }: | |||
There was a problem hiding this comment.
I think you used the wrong formatter. The nixfmt you should use is nixfmt-rfc-style
| { lib, buildNpmPackage, fetchFromGitHub, }: | |
| { | |
| lib, | |
| buildNpmPackage, | |
| fetchFromGitHub, | |
| }: |
|
@404Wolf Thanks, can you also change the PR title to |
|
Makes sense. Thank you! Your feedback and help has been really phenomenal |
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.
Solves #331854
Not sure what to do for a test here. This is my first time contributing, I tried to follow the guides but I'm happy to fix up anything I inevitably messed up.