-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ypbind-mt package #333099
add ypbind-mt package #333099
Conversation
|
||
outputs = [ "out" ]; | ||
|
||
configurePhase = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain your code here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the configurePhase/installPhase
settings the derivation tried to install the files to the global root /
directory.
Has been fixed in my refactor commit 97c8bec
(#333099)
Roughly speaking, XMLLINT requires some files (in a XSLT format) so that it knows what to do - think on it as providing a map with instructions to a human person. Then you need to provide these XSLT files somehow. Usually Nixpkgs provides them already. |
The Makefile has a hardcoded http url to a xml style sheet, see here and I see two solutions:
By chance I tried the official release tarball from the repos release page and it worked without the problems I had with the I think this is the preferable solution and made a commit for this. @AndersonTorres Do you see any remaining issues with the PR? |
Usually we prefer to use the pristine source code, so that we have more control over the build process. But for now let's pick the tarball. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides, LGTM
Now get rid of that excess of Semantic Commits and follow our commit conventions: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions |
Just to make sure I understand correctly how to proceed:
|
Yes. Get rid of that truckload of "feat/fix/style/etc". Only things are
|
449086d
to
a62ec9e
Compare
Most projects I have worked on before use conventional commits so I used that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 333099
run on x86_64-linux 1
1 package built:
- ypbind-mt
This is the first time I submit a pull request to nixpkgs.
I read and tried to adhere to the contributing guidelines on a best effort basis.
If there is still something wrong/missing or needs change I will gladly update the PR.
Description of changes
This pull request adds the package ypbind-mt which contains the
ypbind
binary needed for NIS clients to bind to NIS servers.Things done
./result/bin/
)Misc
The company I work at is using NIS/YP and the necessary tools are still missing in nixpkgs.
This is intended to be the first in a series of packages needed to create usable NIS clients (yp-tools and libnss_nis will follow).
This deviation was created and successfully built/used on a NixOS machine.
A few changes to the Makefile for manpages are necessary.
I did not find a way to prevent xmllint from trying to access the network.
Maybe there is a better way than commenting out the respective lines using
sed
?Best regards
BarrOff