Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.textual: 0.72.0 -> 0.79.0 #333360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greg-hellings
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from joelkoen August 9, 2024 03:49
@greg-hellings greg-hellings changed the title python312Packages.textual: 0.72.0 -> 0.75.1 python312Packages.textual: 0.72.0 -> 0.76.0 Aug 10, 2024
@greg-hellings greg-hellings force-pushed the textual-0.75.0 branch 3 times, most recently from 47ebd83 to a9853d5 Compare August 22, 2024 15:39
@pbsds
Copy link
Member

pbsds commented Aug 22, 2024

the build failure strikes me as a concurrency issue, consider removing pytest-xdist

@greg-hellings
Copy link
Contributor Author

the build failure strikes me as a concurrency issue, consider removing pytest-xdist

Correct. I checked with upstream and they suggest adding the flag I put in with the last edit to force group execution. Some of their tests rely on state from previous tests in the same group.

@greg-hellings greg-hellings changed the title python312Packages.textual: 0.72.0 -> 0.76.0 python312Packages.textual: 0.72.0 -> 0.77.0 Aug 22, 2024
@pbsds
Copy link
Member

pbsds commented Aug 23, 2024

but it still breaks

@greg-hellings
Copy link
Contributor Author

but it still breaks

Where? I added the group argument and it now passes, because it runs all the related tests from the group in a single thread. The run you linked appears to be from before I added the extra flag, from what I can tell.

@greg-hellings
Copy link
Contributor Author

image #333360 (checks) logs.ofborg.org?key=nixos/nixpkgs.333360&attempt_id=2660e8f1-e1b9-4e3b-a151-1b47d073d621

That's from the previous commit where I hadn't added the options, from what I can tell.

@greg-hellings greg-hellings changed the title python312Packages.textual: 0.72.0 -> 0.77.0 python312Packages.textual: 0.72.0 -> 0.79.0 Aug 30, 2024
@taha-yassine
Copy link
Contributor

Any chance this gets merged soon? I need it for a downstream dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants