Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kanidm: 1.2.3 -> 1.3.2 #333366

Merged
merged 2 commits into from
Aug 10, 2024
Merged

kanidm: 1.2.3 -> 1.3.2 #333366

merged 2 commits into from
Aug 10, 2024

Conversation

adamcstephens
Copy link
Contributor

@adamcstephens adamcstephens commented Aug 9, 2024 •
edited
Loading

Description of changes

https://github.com/kanidm/kanidm/releases/tag/v1.3.0
https://github.com/kanidm/kanidm/releases/tag/v1.3.1
https://github.com/kanidm/kanidm/releases/tag/v1.3.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from erictapen and Flakebi August 9, 2024 04:53
@alyssais alyssais mentioned this pull request Aug 9, 2024
Open
@adamcstephens adamcstephens changed the title kanidm: 1.2.3 -> 1.3.1 kanidm: 1.2.3 -> 1.3.2 Aug 10, 2024
@adamcstephens adamcstephens marked this pull request as ready for review August 10, 2024 03:16
@emilazy
Copy link
Member

emilazy commented Aug 10, 2024

Looks like the test is broken.

@adamcstephens
Copy link
Contributor Author

Looks like the test is broken.

No, ofborg just struggles with these tests.

I’m also inclined to remove the security flag since the issue was introduced in 1.3.0 so we’ve yet to ship the affected version.

emilazy
emilazy approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I removed it already when I realized I misread the affected versions, sorry.

Result of nixpkgs-review pr 333366 run on aarch64-linux 1

1 test built:
  • nixosTests.kanidm

@adamcstephens adamcstephens merged commit e76d867 into NixOS:master Aug 10, 2024
35 of 36 checks passed
@adamcstephens adamcstephens deleted the kanidm/1.3.1 branch August 10, 2024 12:23
@adamcstephens
Copy link
Contributor Author

The test run from x86_64

/nix/store/cf9q5iqz1sfx6h6plqmbrwqmdngl73p2-vm-test-run-kanidm

@adamcstephens adamcstephens restored the kanidm/1.3.1 branch August 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy approved these changes

@erictapen erictapen Awaiting requested review from erictapen

@Flakebi Flakebi Awaiting requested review from Flakebi

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamcstephens @emilazy