Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/azure: add Gen 2 VM, aarch64 and accelerated networking support #333508

Merged
merged 9 commits into from
Aug 30, 2024

Conversation

codgician
Copy link
Contributor

@codgician codgician commented Aug 9, 2024

Description of changes

[azure-agent]

  • Removed x86 assertion as the latest waagent already works on aarch64.

[azure-common]

  • Added option to enable support for accelerated networking, following official doc for custom vm image: virtualisation.azure.acceleratedNetworking = true.
  • Remove reference of headless profile to make the console input work (and being able to select boot entries).

[azure-image]

  • Added option for generating Gen 2 VM image (efi partition): virtualisation.azureImage = "v1" or "v2".
  • Added option for specifying esp partition size: virtualisation.azureImage.bootSize

I have created an example flake for generating a test vhd for this change: github:codgician/azure-aarch64-nixos.

The result is promising:

image

image

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4451

@zimbatm zimbatm requested review from teto and kurnevsky August 28, 2024 13:30
@zimbatm
Copy link
Member

zimbatm commented Aug 28, 2024

thanks for your work!

Given the modules haven't been touched since 2016, I propose to merge your work once you confirm that everything is working as intended.

@zimbatm
Copy link
Member

zimbatm commented Aug 30, 2024

Assuming that the 👍 means it's all good

@zimbatm zimbatm merged commit 1e9fccb into NixOS:master Aug 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants