catboost: use llvm 14 for cuda & format with nixfmt-rfc-style #333562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
pbsds
reviewed
Aug 16, 2024
RossComputerGuy
force-pushed
the
feat/catboost-llvm-upgrade
branch
from
e19db93
to
53914c7
Compare
ofborg
bot
added
10.rebuild-linux: 0
and removed
10.rebuild-linux: 1
10.rebuild-linux: 1-10
labels
| @@ -19707,6 +19707,7 @@ with pkgs; | |||
| catboost = callPackage ../development/libraries/catboost { | |||
| # https://github.com/catboost/catboost/issues/2540 | |||
| cudaPackages = cudaPackages_11; | |||
| llvmPackagesCuda = llvmPackages_14; | |||
There was a problem hiding this comment.
Yeah ideally we'd accommodate in cudaPackages (the same logic that handles gcc version ranges) but admittedly that might take a non-trivial refactoring and it's ok to postpone it. CC @NixOS/cuda-maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Upgrade to a newer LLVM version for CUDA (related #305146), format so CI doesn't complain.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.