Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpanel: fix cross compilation, enable strictDeps #333563

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Aug 9, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Aug 9, 2024
@NickCao
Copy link
Member Author

NickCao commented Aug 10, 2024

Result of nixpkgs-review pr 333563 run on x86_64-linux 1

87 packages built:
  • adapta-gtk-theme
  • budgie-analogue-clock-applet
  • budgie-control-center
  • budgie-control-center.debug
  • budgie-desktop
  • budgie-desktop-with-plugins
  • budgie-desktop.dev
  • budgie-desktop.man
  • budgie-gsettings-overrides
  • budgie-user-indicator-redux
  • fm
  • gnome-browser-connector
  • gnome-builder
  • gnome-builder.devdoc
  • gnome-tweaks
  • gnome.gnome-control-center
  • gnome.gnome-control-center.debug
  • gnome.gnome-session
  • gnome.gnome-session.debug
  • gnome.gnome-session.sessions
  • gnome.gnome-shell
  • gnome.gnome-shell.debug
  • gnome.gnome-shell.devdoc
  • gnome.mutter
  • gnome.mutter.debug
  • gnome.mutter.dev
  • gnome.mutter.devdoc
  • gnome.mutter.man
  • gnome.mutter43
  • gnome.mutter43.debug
  • gnome.mutter43.dev
  • gnome.mutter43.devdoc
  • gnome.mutter43.man
  • gnome.nixos-gsettings-overrides
  • gnomeExtensions.easyScreenCast
  • gnomeExtensions.gsconnect
  • gnomeExtensions.gsconnect.installedTests
  • libpanel
  • libpanel.dev
  • libpanel.devdoc
  • magpie
  • magpie.debug
  • magpie.dev
  • magpie.devdoc
  • matrix-gtk-theme
  • mojave-gtk-theme
  • monitor
  • nightfox-gtk-theme
  • pantheon.elementary-greeter
  • pantheon.elementary-gsettings-schemas
  • pantheon.elementary-session-settings
  • pantheon.elementary-shortcut-overlay
  • pantheon.gala
  • pantheon.switchboard-plug-a11y
  • pantheon.switchboard-plug-bluetooth
  • pantheon.switchboard-plug-mouse-touchpad
  • pantheon.switchboard-plug-pantheon-shell
  • pantheon.switchboard-plug-power
  • pantheon.switchboard-plug-security-privacy
  • pantheon.switchboard-with-plugs
  • pantheon.wingpanel
  • pantheon.wingpanel-applications-menu
  • pantheon.wingpanel-indicator-a11y
  • pantheon.wingpanel-indicator-bluetooth
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-indicator-keyboard
  • pantheon.wingpanel-indicator-network
  • pantheon.wingpanel-indicator-nightlight
  • pantheon.wingpanel-indicator-notifications
  • pantheon.wingpanel-indicator-power
  • pantheon.wingpanel-indicator-session
  • pantheon.wingpanel-indicator-sound
  • pantheon.wingpanel-with-indicators
  • phoc
  • phosh
  • phosh-mobile-settings
  • pods
  • schemes
  • sysprof
  • sysprof.dev
  • sysprof.lib
  • tokyonight-gtk-theme
  • vala-language-server
  • vimix-gtk-themes
  • whitesur-gtk-theme
  • wingpanel-indicator-ayatana
  • zrythm

Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@ofborg ofborg bot requested a review from jtojnar August 10, 2024 21:20
@jtojnar jtojnar merged commit f1fed45 into NixOS:master Aug 10, 2024
27 of 29 checks passed
@NickCao NickCao deleted the libpanel branch August 10, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants