Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-bug: add maintainer: sudoforge #333599

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

sudoforge
Copy link
Contributor

@sudoforge sudoforge commented Aug 10, 2024

Description of changes

I'm a maintainer of git-bug, and would like to contribute to nixpkgs by becoming a maintainer of this package.

For verification purposes, my key is available on keys.openpgp.org:

gpg --keyserver hkps://keys.openpgp.org --recv-keys 0xA94F11EEB2E3CE15

or see their documentation for pulling it via Tor.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be splited in two commits.

@sudoforge sudoforge force-pushed the git-bug/add-maintainer-sudoforge branch from c65e72f to 5f16edb Compare August 10, 2024 22:15
@sudoforge
Copy link
Contributor Author

This PR needs to be splited in two commits.

sure thing. i've force-pushed to the tree, removing the addition of myself to the list of maintainers for the given package.

@sudoforge sudoforge changed the title git-bug: add maintainer: sudoforge maintainers: add sudoforge Aug 10, 2024
@drupol
Copy link
Contributor

drupol commented Aug 10, 2024

You can add a second commit to add you to the package in here too. There's no need to make a second PR for that.

@sudoforge sudoforge changed the title maintainers: add sudoforge git-bug: add maintainer: add sudoforge Aug 10, 2024
@sudoforge sudoforge changed the title git-bug: add maintainer: add sudoforge git-bug: add maintainer: sudoforge Aug 10, 2024
@sudoforge
Copy link
Contributor Author

@drupol alright, done.

@drupol drupol merged commit 6c0d992 into NixOS:master Aug 11, 2024
38 of 39 checks passed
@sudoforge sudoforge deleted the git-bug/add-maintainer-sudoforge branch August 11, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants