Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsbkb: patch time crate for Rust 1.80 #333605

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

ProducerMatt
Copy link
Member

@ProducerMatt ProducerMatt commented Aug 10, 2024

Description of changes

Update to dodge #332957

Also remove rec because nix-tidyf complained.

Result of nixpkgs-review pr 333605 run on x86_64-linux 1

1 package built:
  • rsbkb

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build looks fine, thanks!

pkgs/tools/text/rsbkb/default.nix Outdated Show resolved Hide resolved
pkgs/tools/text/rsbkb/default.nix Outdated Show resolved Hide resolved
@ProducerMatt
Copy link
Member Author

Was I correct to base the PR against staging-next?

@ProducerMatt ProducerMatt changed the title rsbkb: 1.4 -> 1.4_823b35 rsbkb: rsbkb: patch time crate for Rust 1.80 Aug 10, 2024
@ProducerMatt ProducerMatt changed the title rsbkb: rsbkb: patch time crate for Rust 1.80 rsbkb: patch time crate for Rust 1.80 Aug 10, 2024
@ProducerMatt ProducerMatt marked this pull request as ready for review August 10, 2024 17:39
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 333605 run on x86_64-linux 1

1 package built:
  • rsbkb

Thanks!

Targeting staging-next is fine, but master would also have been fine. If staging-next had already merged, we’d have to retarget it on master. For something like this I would generally base it on and target master but use nixpkgs-review to check that it works rebased on top of the staging-next cycle with the breaking change.

@emilazy emilazy merged commit b110ca4 into NixOS:staging-next Aug 11, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants