gnome: Move the remaining packages to top-level #338583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
6.topic: GNOME
jtojnar
force-pushed
the
gnome-final-extraction
branch
from
769744c
to
7cb6c78
Compare
Go ahead :-) |
jtojnar
force-pushed
the
gnome-final-extraction
branch
from
7cb6c78
to
8fcb5c5
Compare
Also switch to finalAttrs pattern and avoid pname rec.
jtojnar
force-pushed
the
gnome-final-extraction
branch
from
8fcb5c5
to
be97263
Compare
Those overrides are pointless, `withGnome = true` is the default since long time ago.
Now, only non-packages remain.
jtojnar
force-pushed
the
gnome-final-extraction
branch
from
be97263
to
e5f4004
Compare
danth
pushed a commit
to danth/stylix
that referenced
this pull request
Sep 2, 2024
In response to this PR: NixOS/nixpkgs#338583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Final step, follow up of #333917.
It is a bit annoying that I did not manage to complete it before GNOME 47 updates but I still want to get it in so that I can just have a simple release notes entry and users do not have to guess which packages are where. I will rebase #333911 once this is merged.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.