Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gapcast: init at 1.0.3 #340971

Merged
merged 1 commit into from
Sep 24, 2024
Merged

gapcast: init at 1.0.3 #340971

merged 1 commit into from
Sep 24, 2024

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Sep 10, 2024

802.11 broadcast analyzer & injector

https://github.com/ANDRVV/gapcast

Related to #81418

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fabaff

This comment was marked as outdated.

@nbraud
Copy link
Contributor

nbraud commented Sep 10, 2024

Result of nixpkgs-review pr 340971 run on aarch64-darwin 1

1 package failed to build:
  • gapcast

nbraud
nbraud previously requested changes Sep 10, 2024
Copy link
Contributor

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The application might need a wrapper for wayland compatibility (currently just crashes without X.org) but that can be a follow-up PR.

However, you should likely set meta.platform, regardless of whether you fix the build on Darwin.

@fabaff fabaff force-pushed the gapcast branch 2 times, most recently from 1f72d6f to b2ce7e0 Compare September 19, 2024 21:37
802.11 broadcast analyzer & injector

https://github.com/ANDRVV/gapcast
@fabaff
Copy link
Member Author

fabaff commented Sep 19, 2024

Result of nixpkgs-review pr 340971 run on x86_64-linux 1

1 package built:
  • gapcast

@fabaff fabaff dismissed nbraud’s stale review September 24, 2024 22:40

Comment addressed

@fabaff fabaff merged commit f07d335 into NixOS:master Sep 24, 2024
24 of 26 checks passed
@fabaff fabaff deleted the gapcast branch September 24, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants