Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llm-ls: fix build with rust 1.80 and on darwin #341889

Merged
merged 1 commit into from
Sep 16, 2024
Merged

llm-ls: fix build with rust 1.80 and on darwin #341889

merged 1 commit into from
Sep 16, 2024

Conversation

maxbrunet
Copy link
Member

@maxbrunet maxbrunet commented Sep 14, 2024 •
edited
Loading

Description of changes

Closes #273596
Closes #274012

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Sep 14, 2024
@ofborg ofborg bot requested a review from jfvillablanca September 14, 2024 18:32
alyssais
alyssais requested changes Sep 15, 2024
View reviewed changes
pkgs/by-name/ll/llm-ls/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ll/llm-ls/package.nix Outdated Show resolved Hide resolved
@alyssais alyssais mentioned this pull request Sep 15, 2024
Open
alyssais
alyssais requested changes Sep 15, 2024
View reviewed changes
pkgs/by-name/ll/llm-ls/package.nix Show resolved Hide resolved
pkgs/by-name/ll/llm-ls/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 15, 2024
@jfvillablanca
Copy link
Member

Result of nixpkgs-review pr 341889 run on x86_64-linux 1

1 package built:
  • llm-ls

@alyssais alyssais merged commit c6ab3b3 into NixOS:master Sep 16, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfvillablanca jfvillablanca jfvillablanca approved these changes

@alyssais alyssais alyssais approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: llm-ls for aarch64-darwin
4 participants
@maxbrunet @jfvillablanca @alyssais @wegank