Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gnome] handle GNOME 47 extensions #343905

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Conversation

honnip
Copy link
Contributor

@honnip honnip commented Sep 23, 2024

Description of changes

#333911

it would be good to rerun the update script later and amend it, but it's not necessary

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@honnip honnip force-pushed the gnome47-extensions branch 2 times, most recently from 29a3fe5 to 989289e Compare September 26, 2024 03:39
@honnip
Copy link
Contributor Author

honnip commented Sep 26, 2024

@bobby285271 I will keep this up to date

Please close when you cherry-picked

@bobby285271
Copy link
Member

bobby285271 commented Sep 26, 2024

I never touched pkgs/desktops/gnome/extensions stuff before so having second pair of eyes will be nice, but in any case I will ensure this get triaged before I rebase #333911.

@bobby285271 bobby285271 marked this pull request as ready for review October 2, 2024 14:45
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes look good according to what I see in the README.

@@ -64,9 +64,10 @@ in rec {
gnome44Extensions = mapUuidNames (produceExtensionsList "44");
gnome45Extensions = mapUuidNames (produceExtensionsList "45");
gnome46Extensions = mapUuidNames (produceExtensionsList "46");
gnome47Extensions = mapUuidNames (produceExtensionsList "47");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all-packages.nix should be updated too.

@bobby285271 bobby285271 merged commit b719e40 into NixOS:gnome Oct 3, 2024
8 of 9 checks passed
@bobby285271
Copy link
Member

I plan to rebase #333911 soon so let's merge, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants