python3Packages.mkdocs-git-committers-plugin-2: init at 2.4.1

[mahtaran]

(Same as #343787, renamed branch in my repo. Apologies for spam.)

Description of changes

ojacques/mkdocs-git-committers-plugin-2, primarily used as an optional dependency of Material for MkDocs.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[natsukium]

Could you enable tests?

Make sure the tests are enabled using for example pytestCheckHook and, in the case of libraries, are passing for all interpreters. If certain tests fail they can be disabled individually. Try to avoid disabling the tests altogether. In any case, when you disable tests, leave a comment explaining why.

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#contributing-guidelines-contributing-guidelines

[mahtaran]

Hmmm, the upstream package does not have any test suite, and since it is a plugin that has to do with Git history, mocking one would be pretty complicated I feel. I explicitly disabled the check for now, but if there's any better way to do it, please let me know!

[mahtaran]

@natsukium thanks for the review! (and apologies for the rookie mistakes.) I believe I have addressed most (if not all) of your concerns, would you mind having another look?