-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm.fetchDeps: multiple workspaces; better pnpmInstallFlags #350751
pnpm.fetchDeps: multiple workspaces; better pnpmInstallFlags #350751
Conversation
ac9bcc3
to
3981d80
Compare
Forgot to push the commits with the related package changes. I expect a good ofborg eval, can't check locally atm sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ofborg failed because you forgot to change pnpmWorkspace
in pnpmDeps
.
Also would you mind splitting up your first commit? It contains many formatting changes that makes the diff a bit hard to read.
Edit: eval fails for some other reason too
Aside from the those and some minor formatting issues that we don't have time for, this LGTM! Tested the 2 affected packages on x86_64-linux. I'm going to sleep and may not be available before this should be merged, I'd appreciate if someone could run a nixpkgs-review on this. |
The formatting changes come from the |
My wisdom is to do |
c201b91
to
9ac2535
Compare
Fixed, a sanity check would be nice though just to double check the code actually makes sense. Evals properly on my machine, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the early approval, packages fail for me even though ofborg and nixpkgs-review passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are talking about formatting here are my nits I held back due to the time pressure. We have ~10 hours to merge this with the pnpmWorkspace
deprecation.
I am sure we will get this merged by then. There are three committers involved/pinged in this thread ^^ |
More like 13¾ hours, for what it’s worth. I agree that we should be okay for time (sorry that I can’t review properly myself, I have my own PRs to rush in before the freeze). |
9ac2535
to
04792da
Compare
Fixed all noted issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! astro-language-server
, bash-language-server
and another pnpm package like heroic
builds.
I started nixpkgs-review (on a different machine) and I'm getting 52 rebuilds compared to the previous 1 rebuild.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, small comments left. Haven't read other comments in the thread.
04792da
to
42fb646
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throws an eval time error when pnpmWorkspace
is both in a package derivation and in pnpm.fetchDeps
, and a build time error when pnpmWorkspace
is only in the derivation, as expected. Those 3 packages build, LGTM.
Adds support for installing multiple PNPM workspace packages' dependencies with the
pnpmWorkspaces
variable, and addspnpmInstallFlags
to other parts of PNPM configuration. Also adds appropriate documentation.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.