Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

killerbee: fix build #355417

Merged
merged 1 commit into from
Nov 14, 2024
Merged

killerbee: fix build #355417

merged 1 commit into from
Nov 14, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Nov 12, 2024

ZHF: #352882

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Bot-wxt1221 Bot-wxt1221 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 12, 2024
@ofborg ofborg bot requested a review from fabaff November 12, 2024 23:24
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 12, 2024
@tjni
Copy link
Contributor

tjni commented Nov 13, 2024

Another way I think we can fix this error is by updating scapy to 2.6.1 in #355586. I think that secdev/scapy#4558 will fix the error in the build log.

@tjni
Copy link
Contributor

tjni commented Nov 14, 2024

Let's resuscitate this. The scapy change will need to go to staging, so this is still worthwhile to unbreak this package now.

@Bot-wxt1221 Bot-wxt1221 reopened this Nov 14, 2024
@Bot-wxt1221
Copy link
Member Author

@tjni OK. According to timeline, staging now won't be merged to 24.11. So we can merge it as ZHF.

@tjni tjni merged commit b23215a into NixOS:master Nov 14, 2024
56 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants