Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify :output & :reporter #9

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Unify :output & :reporter #9

merged 5 commits into from
Nov 19, 2024

Conversation

NoahTheDuke
Copy link
Owner

@NoahTheDuke NoahTheDuke commented Nov 19, 2024

Closes #7

->config now handles converting :output (external) to :reporter (internal). :output must be a symbol or sequence of symbols, and :reporter is a function. Logic for changing simple symbols to lazytest.reporters namespaced symbols now happens in ->config as well, so that all of the configuration-related logic is happening there instead of spread across the namespaces (cli, main, etc).

@seancorfield
Copy link

Once this is merged, I'll make a pass over my test runners and remove the :reporter references. Since the defaulting and qualifying is happening further down the call stack, I suspect I can simplify my code quite a bit! Thank you.

@NoahTheDuke NoahTheDuke merged commit 8abdfa9 into main Nov 19, 2024
6 checks passed
@NoahTheDuke NoahTheDuke deleted the nb/unify-output-reporters branch November 19, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unify :output and :reporters
2 participants