Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune cargo-watch usage #65

Closed
laniakea64 opened this issue Dec 12, 2023 · 1 comment · Fixed by #68
Closed

Tune cargo-watch usage #65

laniakea64 opened this issue Dec 12, 2023 · 1 comment · Fixed by #68
Labels

Comments

@laniakea64
Copy link
Collaborator

While trying to fix quoting issues in our tests justfile, noticed that our just watch recipe is suboptimal. Not sure about some aspects of fixing it and have some questions:

  • --debug is for debugging cargo-watch, and its output overwhelms the actual output we're interested in. Why is this flag being used? Can we remove it?

  • run {{FILTER}} is ambiguous when used with our current test suite. How flexible do we want just watch to be? For example, do we want to reuse just watch for the ftdetect tests, with FILTER being --bin=test-ftdetect for that use? or use a separate recipe for watch run ftdetect tests? or have the watch recipe run both syntax & ftdetect tests, passing {{FILTER}} to the syntax tests?

@laniakea64
Copy link
Collaborator Author

--debug is for debugging cargo-watch, and its output overwhelms the actual output we're interested in. Why is this flag being used?

Can't figure this out, even after trying what would've been the current version of cargo-watch at the time this flag was first committed. Wondering if it was unintentionally committed, only added to help confirming the recipe worked as intended?

run {{FILTER}} is ambiguous when used with our current test suite. How flexible do we want just watch to be?

My inclination would be, instead of just watch running cargo directly, have it run just to run other recipes in the tests justfile, specified as recipe parameter. We can use just function error() with conditionals to prevent the recursive just watch watch. Would this be reasonable?

@laniakea64 laniakea64 linked a pull request Dec 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant