Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: improve just watch #68

Merged
merged 2 commits into from
Jan 12, 2024
Merged

tests: improve just watch #68

merged 2 commits into from
Jan 12, 2024

Conversation

laniakea64
Copy link
Collaborator

Proposed fix for #65 . Also update README.md to reflect these changes, mention the ftdetect tests, and clarify the nature of the parameter passed to just run.

@laniakea64 laniakea64 linked an issue Dec 24, 2023 that may be closed by this pull request
 - compile test runner before watching
 - run user-specified tests justfile recipe instead of hard-coded cargo command
 - quote parameters
@laniakea64
Copy link
Collaborator Author

Hi @NoahTheDuke so the reasons I proposed this PR for review instead of going ahead pushing to main are:

  1. I don't know the history of just watch, as in why it was originally done the way it was? So not sure how this change meshes with that, or if that's important.

  2. I don't know if the change in behavior of just watch would break your workflow 😮

  3. Not sure if the changes to README.md make it too verbose?

Would appreciate your take on these when you get to review this, thanks.

@NoahTheDuke
Copy link
Owner

just watch was most useful when I was iterating on the syntax. I'd make a change and the tests would rerun, so i could see the output immediately. I don't know how useful it is now that the syntax is fairly stable.

I don't have any opinions on the code at this point, it's been a while since I had to touch any of this, so I welcome your changes/opinions as the more active dev.

@laniakea64
Copy link
Collaborator Author

Thanks @NoahTheDuke , in that case I'll go ahead and merge this.

I don't know how useful it is now that the syntax is fairly stable.

Although I haven't used just watch much, some things in the syntax are tricky to get right, and an updated just watch could be nice to have for those cases.

@laniakea64 laniakea64 merged commit e955341 into main Jan 12, 2024
1 check passed
@laniakea64 laniakea64 deleted the watch branch January 12, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tune cargo-watch usage
2 participants