test runner: cleanup on Ctrl+C/SIGINT #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #45
I took another look into this, and this time something clicked about how to use
ctrlc
crate (which BTWjust
also uses), so decided to give this a try. Still don't really know what I'm doing in Rust, so @NoahTheDuke your code review would be much welcome, thanks 🙂About test runner performance and this PR:
piped
is such a performance improvement overnull
?? 👀 This doesn't seem to be the case for stdin or stdout.cargo-audit
warning that we are using a yanked crate (ahash
version 0.8.3, reasoning for the yank explained on their wiki), so the question of updating Cargo deps again should be investigated, but let's address that separately.