Skip to content

Commit

Permalink
Fix running evaluation (#218)
Browse files Browse the repository at this point in the history
* Don't assign output files during eval mode

* Update changelog
  • Loading branch information
bittremieux authored Aug 8, 2023
1 parent fba790d commit 4aafa73
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- Don't try to assign non-existing output writer during eval mode.

## [3.4.0] - 2023-06-19

### Added
Expand Down
2 changes: 1 addition & 1 deletion casanovo/denovo/model_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def _execute_existing(
if len(peak_filenames := _get_peak_filenames(peak_path, peak_ext)) == 0:
logger.error("Could not find peak files from %s", peak_path)
raise FileNotFoundError("Could not find peak files")
else:
elif out_writer is not None:
out_writer.set_ms_run(peak_filenames)
peak_is_index = any(
[os.path.splitext(fn)[1] in (".h5", ".hdf5") for fn in peak_filenames]
Expand Down

0 comments on commit 4aafa73

Please sign in to comment.