Fix custom residues in config #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 7, 2023
Codecov Report
@@ Coverage Diff @@
## dev #229 +/- ##
==========================================
+ Coverage 88.91% 89.13% +0.22%
==========================================
Files 12 12
Lines 902 902
==========================================
+ Hits 802 804 +2
+ Misses 100 98 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wfondrie
approved these changes
Aug 15, 2023
bittremieux
added a commit
that referenced
this pull request
Aug 16, 2023
* Fix specifying custom residues * Update changelog
bittremieux
added a commit
that referenced
this pull request
Aug 16, 2023
* Fix specifying custom residues * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom residues in the config file were ignored, making it impossible to retrain Casanovo with now PTMs for example.
Fixes #228, fixes #227.