Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ on how to change the LR scheduler #294

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

bittremieux
Copy link
Collaborator

Supersedes #293 because I messed up. Because there was some categorization added to the FAQ I changed the merge point to base instead of dev, but that also pulled in changes in dev to main, which we only want to do as part of a new release. When changing back to dev, that then pulled changes from main to dev, which is also undesired. Tldr: I made a mess. Easier to quickly create a new PR.

I also removed the links to specific lines of code. When we make changes in this file the links wouldn't correspond with the latest code anymore, which might lead to confusion. Instead, power users that want to change the LR schedule should be able to find the appropriate location based on the provided description.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3d2bba) 89.54% compared to head (1d41d11) 89.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   89.54%   89.54%           
=======================================
  Files          12       12           
  Lines         918      918           
=======================================
  Hits          822      822           
  Misses         96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melihyilmaz melihyilmaz merged commit dae8392 into main Feb 14, 2024
7 checks passed
@melihyilmaz melihyilmaz deleted the lr_schedule_faq branch February 14, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants