Rename max_iters to cosine_schedule_period_iters

[bittremieux]

Fixes #242.

cosine_schedule_period_iters better reflects what this config option does, and has correspondingly been renamed.

The config loader checks whether max_iters is specified and automatically remaps it to cosine_schedule_period_iters, while warning the user about this renaming.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83a1ce4) 89.64% compared to head (0c0ccaa) 89.77%.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #300      +/-   ##
==========================================
+ Coverage   89.64%   89.77%   +0.13%     
==========================================
  Files          12       12              
  Lines         917      929      +12     
==========================================
+ Hits          822      834      +12     
  Misses         95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[melihyilmaz]

When I ran the branch locally to fine-tune v4.0 weights, I got the error below:

optimizer = torch.optim.Adam(self.parameters(), **self.opt_kwargs)
TypeError: Adam.init() got an unexpected keyword argument 'max_iters'

Since max_iters is still in the ckpt file, we pick it up as a part of kwargs. I think we can manually delete it from the current ckpts but I'm not sure if that'd break anything @bittremieux.

[bittremieux]

Ideally we fix it in the code as well. Otherwise other people who try fine-tuning will have the same problem.

I added a unit test to check this and added a fix to remove unrecognized hyperparameters during model loading. This seems to work, but I find it a bit less elegant than the previous fix, because now we're changing config options both in Config and in Spec2Pep. Do you see any alternative solutions @melihyilmaz @wfondrie?

[melihyilmaz]

Everything works for me now locally but I can't think of a more elegant alternative.