Log optimizer and training metrics to CSV file #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #376 +/- ##
==========================================
- Coverage 94.40% 94.36% -0.05%
==========================================
Files 12 12
Lines 1073 1083 +10
==========================================
+ Hits 1013 1022 +9
- Misses 60 61 +1 ☔ View full report in Codecov by Sentry. |
bittremieux
requested changes
Sep 19, 2024
Lilferrit
commented
Sep 19, 2024
bittremieux
approved these changes
Sep 20, 2024
|
Looks good. Please update the CHANGELOG before merging. We might have forgotten to update the CHANGELOG for #374, so can you add that as well? |
Lilferrit
added a commit
that referenced
this pull request
Sep 25, 2024
* eval metrics bug fix * better eval metrics bug fix * eval metrics bug fix * better eval metrics bug fix * eval stats unit test, circular import fix * log metrics unit test * removed unused import * log metrics refactor, additional log metrics test case * aa_match_batch hanles none, additional skipped spectra test cases * Log optimizer and training metrics to CSV file (#376) * csv logger * optimizer metrics logger * metrics logging unit tests * config item retrieval, additional requested changes * Generate new screengrabs with rich-codex * changelog update * Generate new screengrabs with rich-codex --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * aa_match_batch and aa_match handle None * top_match eval metrics warning * removed unused import * log metrics refactor, additional log metrics test case * aa_match_batch hanles none, additional skipped spectra test cases * aa_match_batch and aa_match handle None * top_match eval metrics warning * eval metrics bug fix * better eval metrics bug fix * eval stats unit test, circular import fix * log metrics unit test * removed unused import * log metrics refactor, additional log metrics test case * aa_match_batch hanles none, additional skipped spectra test cases * aa_match_batch and aa_match handle None * top_match eval metrics warning * removed unused import * log metrics refactor, additional log metrics test case * metrics file logging bug fix * aa_match test cases, minor aa_match refactor --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented logging of optimizer (e.g. learning rate and weight decay) and training (e.g. validation and train loss) to a CSV file using
lightning.pytorch.loggers.CSVLogger. Also added an additional callback to log optimizer metrics.