Add CLI command to list transactions for a given deployment #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcuadrado
reviewed
Oct 17, 2024
alcuadrado
reviewed
Oct 17, 2024
alcuadrado
reviewed
Oct 17, 2024
alcuadrado
reviewed
Oct 17, 2024
zoeyTM
force-pushed
the
list-transactions
branch
from
b606030
to
745a80c
Compare
zoeyTM
force-pushed
the
list-transactions
branch
from
745a80c
to
1fb7c0f
Compare
alcuadrado
reviewed
Oct 23, 2024
| ); | ||
|
|
||
| const networkInteraction = | ||
| exState.networkInteractions[message.networkInteractionId - 1]; |
There was a problem hiding this comment.
This -1 caught me by surprise tbh. Do we always have the network interaction ids be 1, 2, 3, ...
TBH I don't remember, and I couldn't find it easily in the code.
There was a problem hiding this comment.
I search the code, and we normally do
const onchainInteraction = executionState.networkInteractions.find(
(interaction) => interaction.id === networkInteractionId
);There was a problem hiding this comment.
The -1 is because i'm indexing it directly, not using a find. As far as I know, we've always started the networkInteraction ID's at 1
alcuadrado
approved these changes
Oct 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #805