Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #500

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

jordaniza
Copy link

Added additional on_attach and capabilities to nvim-lspconfig

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

The Language server for hardhat works great with the config in the readme, but I found a couple of features missing:

  • Error diagnostics were being shown in the editor, but the keybinding to open the modal was not expanding the full error.
  • Docstrings and signatures were not being loaded with

Both of these are a bit of a pain to work without, so added the recommended additional lines to the LSP config for neovim.

Let me know what you think.

Added additional on_attach and capabilities to nvim-lspconfig
@codecov-commenter
Copy link

Codecov Report

Merging #500 (3ae2b9e) into development (d85c38b) will not change coverage.
The diff coverage is n/a.

❗ Current head 3ae2b9e differs from pull request most recent head 450dcf6. Consider uploading reports for the commit 450dcf6 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           development     #500   +/-   ##
============================================
  Coverage        53.23%   53.23%           
============================================
  Files              188      188           
  Lines             4824     4824           
  Branches           793      793           
============================================
  Hits              2568     2568           
  Misses            2019     2019           
  Partials           237      237           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants