Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply get_metric_with_all_outputs on train step #210

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

illian01
Copy link
Collaborator

Description

Please include a summary in English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #209

You should link at least one existing issue for PR. Before your create a PR, please check to see if there is an issue for this change.
PRs from forked repository not accepted.

Change(s)

  • Modify get_metric_with_all_outputs method of base pipeline and all tasks.
  • Collect samples and call get_metric_with_all_outputs in train phase.

Changelog

If you PR to dev branch, please add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file and include a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

@illian01 illian01 self-assigned this Oct 30, 2023
@illian01 illian01 changed the title 209 train metric with entire output Apply get_metric_with_all_outputs on train step Oct 30, 2023
@illian01 illian01 marked this pull request as ready for review October 30, 2023 16:34
@illian01 illian01 requested a review from deepkyu as a code owner October 30, 2023 16:34
Copy link
Contributor

@deepkyu deepkyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revision. I added some comments :)

src/netspresso_trainer/pipelines/base.py Outdated Show resolved Hide resolved
@illian01 illian01 requested a review from deepkyu October 31, 2023 06:45
@illian01 illian01 merged commit 37f61f4 into dev Oct 31, 2023
2 checks passed
@illian01 illian01 deleted the 209-train-metric-with-entire-output branch November 1, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sprint] Apply get_metric_with_all_outputs on train step
2 participants