Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff rule: W(warning) #218

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Add ruff rule: W(warning) #218

merged 3 commits into from
Nov 3, 2023

Conversation

deepkyu
Copy link
Contributor

@deepkyu deepkyu commented Nov 3, 2023

Description

Please include a summary in English, of the changes in this pull request. If it closes an issue, please mention it here.

Closes: #216

You should link at least one existing issue for PR. Before your create a PR, please check to see if there is an issue for this change.
PRs from forked repository not accepted.

Change(s)

  • Add W rule to apply with ruff rules

Changelog

If you PR to dev branch, please add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file and include a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

@deepkyu deepkyu requested a review from illian01 as a code owner November 3, 2023 03:00
@deepkyu deepkyu linked an issue Nov 3, 2023 that may be closed by this pull request
1 task
Copy link
Collaborator

@illian01 illian01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks good to me!

@deepkyu deepkyu merged commit 11128f7 into dev Nov 3, 2023
2 checks passed
@deepkyu deepkyu deleted the 216-add-ruff-rule-wwarning branch November 3, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add ruff rule: W(warning)
2 participants