Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!HOTFIX] Handle error when saving model checkpoints and artifacts #580

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

hglee98
Copy link
Contributor

@hglee98 hglee98 commented Nov 1, 2024

Description

A critical issue is identified when training models containing re-parametrizable blocks. This issue occurs because the original model structure changes during the checkpoint saving process. To resolve this, I implement a deepcopy function that runs before saving the model artifacts.

Change(s)

  • Add deepcopy function before conducting reparam

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

Changelog

If your PR is granted to dev branch, codeowner will add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file including a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

Please enable Allow edits and access to secrets by maintainers so that our maintainers can update the CHANGELOG.md.

@hglee98 hglee98 requested a review from illian01 as a code owner November 1, 2024 07:48
@hglee98 hglee98 changed the title [!HOTFIX] Add deepcopy when saving checkpoint [!HOTFIX] Handle error when saving model checkpoints and artifacts Nov 5, 2024
Copy link
Collaborator

@illian01 illian01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@illian01 illian01 merged commit 3a83fb2 into Nota-NetsPresso:dev Nov 12, 2024
2 checks passed
@illian01 illian01 added the bug Something isn't working label Nov 12, 2024
@hglee98 hglee98 deleted the hotfix-model-deploy branch December 6, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants