Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!HOTFIX] Add use_identity argument to load rt-detr pre-trained weights correctly #594

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

hglee98
Copy link
Contributor

@hglee98 hglee98 commented Nov 28, 2024

Description

This PR aims to fix the issue when loading RT-DETR pre-trained weights

Related to #581

We recommend to link at least one existing issue for PR. Before your create a PR, please check if there is an issue for this change.

Change(s)

  • Add use_identity parameter to load rt-detr pre-trained weights correctly

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

Changelog

If your PR is granted to dev branch, codeowner will add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file including a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

Please enable Allow edits and access to secrets by maintainers so that our maintainers can update the CHANGELOG.md.

@hglee98 hglee98 requested a review from illian01 as a code owner November 28, 2024 05:51
@hglee98 hglee98 changed the title [!HOTFIX] Add use_identity block to load rt-detr pre-trained weights correctly [!HOTFIX] Add use_identity argument to load rt-detr pre-trained weights correctly Nov 28, 2024
Copy link
Collaborator

@illian01 illian01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@illian01 illian01 added the bug Something isn't working label Dec 3, 2024
@illian01 illian01 merged commit 1419918 into Nota-NetsPresso:dev Dec 3, 2024
4 checks passed
@hglee98 hglee98 deleted the hotfix-rtdetr-repvgg branch December 6, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants