Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Implement yolov9 loss #595

Merged
merged 10 commits into from
Dec 3, 2024
Merged

Conversation

hglee98
Copy link
Contributor

@hglee98 hglee98 commented Nov 28, 2024

Description

This PR aims to support yolov9 loss feature.

Related to #582.

Change(s)

  • Implement yolov9 loss

TODOs for later

  • topk, factor attr in BoxMatcher should be controlled by config.
  • BoxMatcher module and caculate_iou method should be moved to bbox_utils module.

Code Formatting

If you PR to either master or dev branch, you should follow the code linting process. Please check your code with lint_check.sh in ./scripts directory.
For more information, please read the contribution guide in CONTRIBUTING.md.

Changelog

If your PR is granted to dev branch, codeowner will add a brief summary of the change to the Upcoming Release section of the CHANGELOG.md file including a link to the PR (formatted in markdown) and a link to your github profile.

For example,

- Added a new feature by `@myusername` in [PR 2023](https://github.com/Nota-NetsPresso/netspresso-trainer/pull/2023)

Please enable Allow edits and access to secrets by maintainers so that our maintainers can update the CHANGELOG.md.

@hglee98 hglee98 requested a review from illian01 as a code owner November 28, 2024 05:58
Copy link
Collaborator

@illian01 illian01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@illian01 illian01 added the enhancement New feature or request label Dec 3, 2024
@illian01 illian01 merged commit 4ab8f8e into Nota-NetsPresso:dev Dec 3, 2024
2 checks passed
@hglee98 hglee98 deleted the 582-yolov9-loss branch December 6, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants