add outcome validation

.github/workflows/security_check.yml

@@ -17,10 +17,17 @@ jobs:
       - name: Install dependencies
         run: yarn install
       - name: Run yarn audit
+        id: audit
         run: yarn audit --no-color --json > yarn-report.json
         continue-on-error: true # we still want to upload the report
       - name: Upload report
         uses: actions/upload-artifact@v4
         with:
           name: yarn-audit-report
           path: yarn-report.json
+      # if yarn audit failed, the job should also fail, but only after the results were uploaded
+      - name: Validate yarn audit outcome
+        if: ${{ steps.audit.outcome == 'failure' }}
+        run: |
+          echo "Yarn audit failed"
+          exit 1