Change useLayoutEffect of useNavigationComponentHooks to useEffect #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed
useLayoutEffect
touseEffect
at useNavigationComponentDidAppear & useNavigationComponentDidDisppear.As you can see, in previous code,
useNavigationComponentDidAppear
worked by usinguseLayoutEffect
toregisterComponentDidAppearListener
to navigation events. (The signature ofuseNavigationComponentDidDisppear
is the same)So if user use setState inside
useNavigationComponentDidAppear
, the next call will not be called because the component will be updated before the next effect is executed.That's why some user experiences this issue : #62
Reference